update canary status before eventing #1780
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luisr-escobar <[email protected]>
|
@aryan9600 @stefanprodan would you be able to take a look at this PR? |
Signed-off-by: luisr-escobar <[email protected]>
Signed-off-by: luisr-escobar <[email protected]>
pkg/controller/scheduler.go
Outdated
|
|
||
| var err error | ||
| // update canary status to ensure checksum is up to date in all webhooks | ||
| if err := canaryController.SyncStatus(canary, flaggerv1.CanaryStatus{Phase: flaggerv1.CanaryPhaseProgressing}); err != nil { |
There was a problem hiding this comment.
I think this will break the whole thing, we can't set CanaryPhaseProgressing here, the canary status is synced only in shouldAdvance.
There was a problem hiding this comment.
@stefanprodan local integration tests are passing and also validated that the image generated by this change works on a dev cluster but to your point I've moved the code block under shouldAdvance
Signed-off-by: luisr-escobar <[email protected]>
|
Hi @stefanprodan please let me know if any further updates are needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a mismatch on the checksum of the generated canary inital events compared to the subsequent events which is caused by the canary object status field
lastAppliedSpecnot being updated before the initial events are sent.